Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokenomics] Preparation for Global Mint Reimbursement Request #755

Merged
merged 61 commits into from
Sep 9, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Aug 22, 2024

Summary

Implement "max claimable amount" in preparation for "global mint reimbursement request".

Specific changes:

  • Added lots of TODO_BETA in preparation for beta testnet
  • Added a lot more comments and explanation in the TLM processors

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

x/tokenomics/keeper/token_logic_modules_test.go Outdated Show resolved Hide resolved
e2e/tests/0_settlement.feature Outdated Show resolved Hide resolved
@Olshansk Olshansk added the tokenomics Token Economics - what else do you need? label Aug 22, 2024
@Olshansk Olshansk added this to the Shannon Beta TestNet Launch milestone Aug 22, 2024
@Olshansk Olshansk self-assigned this Aug 23, 2024
@Olshansk Olshansk changed the title [WIP][Tokenomics] Preparation for Global Mint Reimbursement Request [Tokenomics] Preparation for Global Mint Reimbursement Request Aug 25, 2024
@Olshansk Olshansk marked this pull request as ready for review August 25, 2024 19:28
@Olshansk Olshansk changed the base branch from main to tokenomic_docs August 26, 2024 21:05
@Olshansk Olshansk changed the title [Tokenomics] Preparation for Global Mint Reimbursement Request [UPDATE BASE BRANCH BEFORE MERGING][Tokenomics] Preparation for Global Mint Reimbursement Request Aug 26, 2024
@Olshansk Olshansk force-pushed the issues/732_max_claimable_pokt branch from 615337f to f79989a Compare August 26, 2024 21:19
@Olshansk Olshansk removed push-image CI related - pushes images to ghcr.io devnet devnet-test-e2e labels Sep 5, 2024
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, I made another pass this morning and didn't realize this review was still pending. 😅

Preemptively approving. Only one final ask regarding splitting token_logic_modules.go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about moving the individual TLM implementations to their own files?

Copy link

github-actions bot commented Sep 9, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 755)
Grafana network dashboard for devnet-issue-755

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Sep 9, 2024
@Olshansk Olshansk merged commit e17a0df into main Sep 9, 2024
10 checks passed
@Olshansk Olshansk deleted the issues/732_max_claimable_pokt branch September 9, 2024 22:51
bryanchriswhite added a commit that referenced this pull request Sep 16, 2024
…ke-transfer

* pokt/main:
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
  [Refactor] Replace embedded Service with ServiceId (#802)
  [Session,Service] Ensure SessionHeader and Service basic validation. (#782)
  [Tokenomics] Preparation for Global Mint Reimbursement Request (#755)
  [Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
  [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801)
  [Documentation] Cosmovisor  (#768)
  [CI] Add cosmovisor to container images (#796)
  Use a descriptive error if service ID is not found (#787)
  [SessionManager] Implement off-chain proof params usage (#765)
  [SDK] Update shannon sdk dependency (#800)
  [E2E Test] Remove redundant logging (#798)
bryanchriswhite added a commit that referenced this pull request Sep 16, 2024
…actor/transfer-msg_period-param

* issues/657/feat/app-stake-transfer:
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
  [Refactor] Replace embedded Service with ServiceId (#802)
  [Session,Service] Ensure SessionHeader and Service basic validation. (#782)
  [Tokenomics] Preparation for Global Mint Reimbursement Request (#755)
  [Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
  [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801)
  [Documentation] Cosmovisor  (#768)
  [CI] Add cosmovisor to container images (#796)
  Use a descriptive error if service ID is not found (#787)
  [SessionManager] Implement off-chain proof params usage (#765)
  [SDK] Update shannon sdk dependency (#800)
  [E2E Test] Remove redundant logging (#798)
bryanchriswhite added a commit that referenced this pull request Sep 16, 2024
…ues/657/chore/app-transfer-period

* issues/657/refactor/transfer-msg_period-param:
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
  [Refactor] Replace embedded Service with ServiceId (#802)
  [Session,Service] Ensure SessionHeader and Service basic validation. (#782)
  [Tokenomics] Preparation for Global Mint Reimbursement Request (#755)
  [Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
  [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801)
  [Documentation] Cosmovisor  (#768)
  [CI] Add cosmovisor to container images (#796)
  Use a descriptive error if service ID is not found (#787)
  [SessionManager] Implement off-chain proof params usage (#765)
  [SDK] Update shannon sdk dependency (#800)
  [E2E Test] Remove redundant logging (#798)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e push-image CI related - pushes images to ghcr.io tokenomics Token Economics - what else do you need?
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants