move facebook app id to config

pol-is · Feb 27, 2018 · 876b94d · 876b94d
1 parent 3691854
commit 876b94d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/gulpfile.js b/gulpfile.js
@@ -256,6 +256,7 @@ gulp.task('index', [
       basepath: basepath,
       basepath_visbundle: basepath_visbundle_dev,
       d3Filename: 'd3.js',
+      fbAppId: polisConfig.FB_APP_ID,
       useIntercom: !isTrue(polisConfig.DISABLE_INTERCOM),
       versionString: versionString,
       domainWhitelist: domainWhitelist,
@@ -266,6 +267,7 @@ gulp.task('index', [
       basepath: basepath, // proxy through server (cached by cloudflare, and easier than choosing a bucket for preprod, etc)
       basepath_visbundle: basepath,
       d3Filename: 'd3.min.js',
+      fbAppId: polisConfig.FB_APP_ID,
       useIntercom: !isTrue(polisConfig.DISABLE_INTERCOM),
       versionString: versionString,
       domainWhitelist: domainWhitelist,

diff --git a/index.html b/index.html
@@ -364,7 +364,7 @@
 <script>
   window.fbAsyncInit = function() {
     FB.init({
-      appId      : '661042417336977',
+      appId      : '<%= fbAppId %>',
       xfbml      : true,
       version    : 'v2.1'
     });

diff --git a/polis.config.template.js b/polis.config.template.js
@@ -12,12 +12,15 @@ module.exports = {
 
   DISABLE_INTERCOM: true,
 
+  FB_APP_ID: '661042417336977',
+
   S3_BUCKET_PROD: 'pol.is',
   S3_BUCKET_PREPROD: 'preprod.pol.is',
 
   SCP_SUBDIR_PREPROD: 'preprod',
   SCP_SUBDIR_PROD: 'prod',
 
+
   UPLOADER: 'scp',
   // UPLOADER: 's3',
 };