fix(rust,python,sql): rework SQL join constraint processing to properly account for all USING columns
#11518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y account for all `USING` columns
alexander-beedie
requested review from
ritchie46,
stinodego,
orlp and
universalmind303
as code owners
github-actions
bot
added
fix
alexander-beedie
force-pushed
the
fix-sql-using-join-constraint
branch
2 times, most recently
from
e947c29 to
2fbdca6
Compare
alexander-beedie
force-pushed
the
fix-sql-using-join-constraint
branch
from
5a53566 to
0d5cedd
Compare
universalmind303
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #11290.
Ref: #11290 (comment)
Ref: #11501 (comment)
Turns out we have been silently eating all columns after the first one in
USINGclauses. I've reworked the processing here so that we now properly capture and apply all of the declared constraint columns, and added/fixed some test coverage.