Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): Move mode operation from core to ops crate #11543

Merged
merged 3 commits into from
Oct 6, 2023
Merged

chore(rust): Move mode operation from core to ops crate #11543

merged 3 commits into from
Oct 6, 2023

Conversation

c-peters
Copy link
Collaborator

@c-peters c-peters commented Oct 5, 2023

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 5, 2023
@c-peters c-peters marked this pull request as draft October 5, 2023 15:02
@c-peters c-peters marked this pull request as ready for review October 5, 2023 17:19
ritchie46
ritchie46 reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the mode feature from polars-core's Cargo.toml as well.

@ritchie46 ritchie46 merged commit aafdb55 into pola-rs:main Oct 6, 2023
@c-peters c-peters deleted the move_mode branch October 6, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 left review comments

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-peters @ritchie46