Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: skip empty chunks in concat #11565

Merged
merged 2 commits into from
Oct 6, 2023
Merged

perf: skip empty chunks in concat #11565

merged 2 commits into from
Oct 6, 2023

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 6, 2023

Fixes #11561.

@orlp orlp requested a review from ritchie46 as a code owner October 6, 2023 12:34
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Oct 6, 2023
@ritchie46
Copy link
Member

ritchie46 commented Oct 6, 2023 •
edited
Loading

The test must be updated a little bit, so we do still get multiple chunks in the test.

@ritchie46 ritchie46 merged commit 4d53ae2 into pola-rs:main Oct 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

Assignees
No one assigned
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chunk sizes for vstacked frames
2 participants
@orlp @ritchie46