fix(rust,python,cli): don't conflate supported UNION ops in the SQL parser with (currently) unsupported UNION "BY NAME" variations #11576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arser with (currently unsupported) UNION "BY NAME" variations
alexander-beedie
requested review from
ritchie46,
stinodego,
orlp and
universalmind303
as code owners
github-actions
bot
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #9370.
Will come back to this and add proper
UNION BY NAMEandUNION ALL BY NAMEsupport later, but we currently silently conflate both of these variations withUNION [DISTINCT].This PR catches such usage and raises a suitable error, eg:
(Will also notice any future flavours of
UNIONthat we don't explicitly support, should any new ones be added to the parser later).