refactor(python): fixes issue with relative location of file used in namespace tests #11588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
alexander-beedie
changed the title
alexander-beedie
force-pushed
the
normalise-namespace-test-files
branch
from
d6744cf to
7cad30d
Compare
ritchie46
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the
namespacetest file location a fixture, and moved the test file into afilessubdir, as we do elsewhere; same approach used for other test directories (such asio).Without this you can get a test error if your working directory doesn't match expectation.
(Also: added a one-line check on
\r\ncsv read/write round-trip as a quick drive-by).