feat(python): Standardize error message format #11598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDataScientistNL
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
TheDataScientistNL
changed the title
stinodego
requested changes
Oct 9, 2023
py-polars/polars/dataframe/frame.py
Outdated
| @@ -3436,14 +3436,15 @@ def write_database( | |||
| elif engine == "sqlalchemy": | |||
| if parse_version(pd.__version__) < parse_version("1.5"): | |||
| raise ModuleNotFoundError( | |||
| f"writing with engine 'sqlalchemy' requires pandas 1.5.x or higher, found pandas {pd.__version__!r}" | |||
| f"writing with engine `sqlalchemy` requires pandas 1.5.x or higher, found pandas {pd.__version__!r}" | |||
There was a problem hiding this comment.
sqlalchemy isn't a code snippet - it's a name of a package. It shouldn't get backticks.
There was a problem hiding this comment.
@stinodego Understood. Whilst editing I saw that packages are sometimes within single quotes, sometimes with CamelCase notation. Any standardization you would like there as well, e.g. always in single quotes and all lowercase?
stinodego
changed the title
github-actions
bot
added
enhancement
stinodego
force-pushed
the
update_error_messages
branch
from
cbd2a97 to
583343a
Compare
stinodego
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10421 for
py-polarsfolder but not rust yet. Some unit tests had to be updated as well due to the new formatting.All files in
py-polarshave been searched onraiseand have been checked on the bullet points mentioned in #10421.