feat(python): Add merge mode to write_delta and remove pyarrow to delta conversions
#12392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
changed the title
MERGE in write_delta and remove pyarrow to delta conversionsMERGE in write_delta and remove pyarrow to delta conversions
github-actions
bot
added
enhancement
stinodego
added
the
do not merge
stinodego
changed the title
MERGE in write_delta and remove pyarrow to delta conversionsmerge mode to write_delta and remove pyarrow to delta conversions
stinodego
requested changes
Nov 12, 2023
stinodego
reviewed
Nov 13, 2023
|
All right, just ping me when this is ready for another look. |
ion-elgreco
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
stinodego
force-pushed
the
feat/add_merge_in_write_delta
branch
from
4c4687c to
0dc5d3a
Compare
stinodego
requested changes
Dec 6, 2023
stinodego
reviewed
Dec 6, 2023
ion-elgreco
force-pushed
the
feat/add_merge_in_write_delta
branch
from
2ed0aed to
0dc5d3a
Compare
|
@stinodego added a test and your suggestion |
stinodego
removed
the
do not merge
stinodego
approved these changes
Dec 6, 2023
|
Great, thanks @stinodego! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11983
@stinodego it's ready to review, but I keep it in DRAFT because we should merge it with main after the functionality of this PR: delta-io/delta-rs#1820 lands in the new release of deltalake, since the schema conversions directly in polars become obsolete.
Once it's available I will update this PR to pin the new version of deltalake.