feat(python): Add "execute_options" support for read_database_uri
#14682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
enhancement
alexander-beedie
force-pushed
the
read-database-uri-execute-options
branch
2 times, most recently
from
033722f to
d4304b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14682 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 1331 1331
Lines 172773 172776 +3
Branches 2455 2456 +1
=======================================
+ Hits 139966 139972 +6
+ Misses 32339 32337 -2
+ Partials 468 467 -1 ☔ View full report in Codecov by Sentry. |
stinodego
suggested changes
Mar 1, 2024
They have an open issue about it here... sfu-db/connector-x#208 ...which includes a mention about why it's a bit tricky to implement. |
alexander-beedie
force-pushed
the
read-database-uri-execute-options
branch
from
d4304b6 to
9729e04
Compare
alexander-beedie
force-pushed
the
read-database-uri-execute-options
branch
from
b07e744 to
92a5151
Compare
stinodego
approved these changes
Mar 7, 2024
alexander-beedie
changed the title
read_database_uriread_database_uri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14631.
The
adbcengine only has limited support for "execute_options" (andconnectorxhas no support at all), but we can still make the API more consistent for those cases where such options are valid (such as use of "parameters" with theadbcengine and a SQLite backend).