-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): support use of KùzuDB via pl.read_database
#14822
feat(python): support use of KùzuDB via pl.read_database
#14822
Conversation
90d8a93
to
f5e1d1a
Compare
pl.read_database
pl.read_database
pl.read_database
pl.read_database
8033c82
to
96edb8d
Compare
96edb8d
to
8cd5331
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14822 +/- ##
==========================================
- Coverage 80.95% 80.94% -0.02%
==========================================
Files 1327 1327
Lines 172080 172081 +1
Branches 2452 2453 +1
==========================================
- Hits 139305 139283 -22
- Misses 32305 32328 +23
Partials 470 470 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I think it's nice to add support for this.
A nitpick / some general questions.
I'll fix the Windows test shortly 🤔 Update: done. |
4e84ef9
to
21e4a27
Compare
21e4a27
to
5d264ef
Compare
5d264ef
to
0803fea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, nice! Thanks Alex.
Quite happy with how the
ConnectionExecutor
abstraction is holding up as it only required a few minor tweaks to add support forkuzu
1 graph database queries (which make use of the Cypher2 query language).Registered it as having Arrow-aware return, so we will always load results efficiently (eg: not via the row iterator), and also made a PR on their side adding direct Polars export support to their QueryResult object; we don't need to wait on that here though, as we can use their existing Arrow export directly (see: kuzudb/kuzu#2985).
Example
Footnotes
KùzuDB: https://kuzudb.com/ ↩
Cypher: https://kuzudb.com/docusaurus/cypher/ ↩