Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Minor refactor of Rust any value constructors #15077

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

stinodego
Copy link
Contributor

Just extracting some logic into functions and moving some stuff around.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Mar 14, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 83.97790% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 81.04%. Comparing base (f08914b) to head (b9829c4).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/series/any_value.rs 83.97% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15077      +/-   ##
==========================================
- Coverage   81.04%   81.04%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      173771   173789      +18     
  Branches     2456     2456              
==========================================
+ Hits       140832   140839       +7     
- Misses      32471    32482      +11     
  Partials      468      468              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review March 15, 2024 07:14
@stinodego stinodego merged commit bb1aa26 into main Mar 15, 2024
18 checks passed
@stinodego stinodego deleted the av-refactor branch March 15, 2024 07:16
@c-peters c-peters added the accepted Ready for implementation label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants