Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust, python): Add cat.to_local() expression #15090

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(rust, python): Add cat.to_local() expression #15090

wants to merge 1 commit into from

Conversation

mcrumiller
Copy link
Contributor

Resolves #14996.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 16, 2024
@mcrumiller mcrumiller marked this pull request as draft March 16, 2024 00:34
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (120ec7f) to head (4d148c8).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/dsl/function_expr/cat.rs 80.00% 1 Missing ⚠️
crates/polars-plan/src/dsl/function_expr/schema.rs 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15090      +/-   ##
==========================================
- Coverage   80.72%   80.72%   -0.01%     
==========================================
  Files        1475     1475              
  Lines      193337   193359      +22     
  Branches     2760     2760              
==========================================
+ Hits       156079   156089      +10     
- Misses      36748    36760      +12     
  Partials      510      510

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcrumiller mcrumiller force-pushed the cat-local-expr branch 4 times, most recently from f2f48f8 to 9367deb Compare March 16, 2024 01:52
@mcrumiller mcrumiller marked this pull request as ready for review March 16, 2024 16:08
@stinodego stinodego requested a review from reswqa as a code owner June 28, 2024 17:53
@mcrumiller
Copy link
Contributor Author

Looks like tests got reorganized, rebasing.

@mcrumiller
Copy link
Contributor Author

@c-peters this one has been sitting around a while, any chance you can approve or reject/close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expr.cat.to_local() is missing
1 participant
@mcrumiller