docs: Explanation in aggregation.md did not match code example #17859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation did not match code example.
alexander-beedie
changed the title
github-actions
bot
added
documentation
| @@ -17,8 +17,7 @@ Per GROUP `"first_name"` we | |||
| <!-- dprint-ignore-start --> | |||
|
|
|||
| - count the number of rows in the group: | |||
| - short form: `pl.count("party")` | |||
| - full form: `pl.col("party").count()` | |||
| - full form: `pl.len()` | |||
There was a problem hiding this comment.
Given that this is now the only form given, doesn't seem to be a need to label it "full form" 🤔
There was a problem hiding this comment.
Removed the "full form" sub line
Remove "full form" as there is only one form for counting number of rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation referenced
pl.count("party")which was not present in the provided code example.See issue #17858