-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add name.replace
to the set of column rename options
#17942
base: main
Are you sure you want to change the base?
Conversation
name.replace
expression to support additional column rename optionsname.replace
expression to the set of column rename options
name.replace
expression to the set of column rename optionsname.replace
to the set of column rename options
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17942 +/- ##
=======================================
Coverage 79.13% 79.13%
=======================================
Files 1572 1572
Lines 219839 219859 +20
Branches 2462 2462
=======================================
+ Hits 173961 173986 +25
+ Misses 45310 45305 -5
Partials 568 568 ☔ View full report in Codecov by Sentry. |
pub fn replace(self, pattern: &str, value: &str, literal: bool) -> Expr { | ||
let value = value.to_string(); | ||
let pattern = pattern.to_string(); | ||
if literal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to move all map
functions to map_private
so that the DSL
can be serialized and has all the information. So this requires a map_private
where we do the expansion upon ir conversion.
dacafb5
to
bb05a8b
Compare
bb05a8b
to
942ed72
Compare
1fc3162
to
339fc9c
Compare
339fc9c
to
30146b4
Compare
30146b4
to
fe03f7a
Compare
Closes #17920.
Handy addition to the set of
name
methods.Example