fix: Adding with_row_index() to previously collected lazy scan does not take effect
#18913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
changed the title
with_row_index ignored on 2nd collect() for scan functionscollect() using with_row_index does not add row index on lazy scanning from file
nameexhaustion
changed the title
collect() using with_row_index does not add row index on lazy scanning from filecollect() using with_row_index does not add row index on lazy scanning from file
github-actions
bot
added
fix
nameexhaustion
changed the title
collect() using with_row_index does not add row index on lazy scanning from filewith_row_index() to previously collected lazy scan does not take effect
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18913 +/- ##
=======================================
Coverage 79.85% 79.86%
=======================================
Files 1521 1521
Lines 206835 206843 +8
Branches 2906 2906
=======================================
+ Hits 165177 165185 +8
Misses 41110 41110
Partials 548 548 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18892
This only happens if the
LazyFrameis a direct scan without any subsequent operations.