Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove failing datetime subclass test #19068

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 2, 2024

@mcrumiller You can re-introduce these when everything works as expected, right now it's causing spurious CI failures.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.77%. Comparing base (b1b322f) to head (a8a4366).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19068      +/-   ##
==========================================
+ Coverage   79.75%   79.77%   +0.02%     
==========================================
  Files        1531     1531              
  Lines      208547   208547              
  Branches     2913     2913              
==========================================
+ Hits       166319   166378      +59     
+ Misses      41677    41618      -59     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit d7c8e68 into pola-rs:main Oct 2, 2024
12 checks passed
@mcrumiller
Copy link
Contributor

Were the date/datetime tests causing issues in addition to the timedelta/time tests?

@c-peters c-peters added the accepted Ready for implementation label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants