-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Revise and improve 'Concepts' section #19087
Conversation
c3e7eca
to
aabbc7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19087 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 1531 1531
Lines 208573 208576 +3
Branches 2913 2913
=======================================
+ Hits 166472 166482 +10
+ Misses 41550 41543 -7
Partials 551 551 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good introduction. I have left some comments, but looks good overall. 👍
docs/source/src/python/user-guide/concepts/data-types-and-structures.py
Outdated
Show resolved
Hide resolved
Simplify the dataframe used in the section 'Reading & Writing' of the getting started page and remove dead code from the respective source files. A smaller DF is better because the focus is on reading/writing, not on the data types supported. It also creates a clearer distinction between the DF from this section and the DF of the section on expressions.
The main focus was on picking one example dataframe that could be used throughout the whole page and to write a more coherent narrative.
Translate all the Python examples to Rust.
Since there is now a coherent story throughout the whole 'getting started' page it no longer makes sense to have three different files with examples for each language.
92bffab
to
5e2e040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review comments. I've addressed all of them and left as “unresolved” those which need you to look at what my changes were.
No description provided.