Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Migrate to hashbrown 0.15 #19091

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 3, 2024

Includes a temporary hack to set the nightly flag on an older hashbrown version until we've eliminated/upgraded all dependencies that depend on hashbrown 0.15. See rust-lang/hashbrown#564 for rationale.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (0cef5b7) to head (bae3e15).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19091      +/-   ##
==========================================
- Coverage   79.77%   79.76%   -0.01%     
==========================================
  Files        1531     1531              
  Lines      208551   208529      -22     
  Branches     2913     2913              
==========================================
- Hits       166369   166336      -33     
- Misses      41631    41642      +11     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit f55658b into pola-rs:main Oct 3, 2024
20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants