refactor(rust): Minor CSV bit twiddle nitpick #19121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19121 +/- ##
==========================================
- Coverage 79.81% 79.80% -0.01%
==========================================
Files 1531 1531
Lines 208576 208596 +20
Branches 2913 2913
==========================================
+ Hits 166466 166470 +4
- Misses 41559 41575 +16
Partials 551 551 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Oct 7, 2024
ritchie46
reviewed
Oct 7, 2024
| let has_any = has_separator | has_eol_char; | ||
| let has_eol_char = simd_bytes.simd_eq(self.simd_eol_char); | ||
| let has_separator = simd_bytes.simd_eq(self.simd_separator); | ||
| let has_any_mask = (has_separator | has_eol_char).to_bitmask(); |
There was a problem hiding this comment.
You rather do that on the SIMD lane than the u64?
There was a problem hiding this comment.
Yes, to_bitmask is a bit more expensive on ARM, so I'd rather do that only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.