Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edit confusing warning message with fsspec URL #19165

Closed
wants to merge 4 commits into from
Closed

fix: Edit confusing warning message with fsspec URL #19165

wants to merge 4 commits into from

Conversation

ComputingVictor
Copy link

@ComputingVictor ComputingVictor commented Oct 9, 2024

Warning message that caused confusion using fsspec URL's.

Solves #19150

Adds

A file URL was detected.
Ensure the scheme (local://) is well-formed and supported.
For better performance, use direct local file paths.

@ComputingVictor ComputingVictor changed the title Fix: Confusing warning message with fsspec URL Fix(warning): Fix Confusing warning message with fsspec URL Oct 9, 2024
@ComputingVictor ComputingVictor changed the title Fix(warning): Fix Confusing warning message with fsspec URL fix(warning): Improve confusing warning message with fsspec URL Oct 9, 2024
@ComputingVictor ComputingVictor changed the title fix(warning): Improve confusing warning message with fsspec URL fix(Rust): Edit confusing warning message with fsspec URL Oct 9, 2024
@ComputingVictor ComputingVictor changed the title fix(Rust): Edit confusing warning message with fsspec URL fix: Edit confusing warning message with fsspec URL Oct 9, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (2e0438b) to head (f18041f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19165      +/-   ##
==========================================
- Coverage   79.82%   79.79%   -0.03%     
==========================================
  Files        1532     1532              
  Lines      208488   208490       +2     
  Branches     2913     2415     -498     
==========================================
- Hits       166416   166359      -57     
- Misses      41521    41585      +64     
+ Partials      551      546       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ComputingVictor ComputingVictor deleted the Fix-#19150-Warning-message branch October 10, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant