-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Allow DeltaTable input to scan_delta and read_delta #19229
feat(python): Allow DeltaTable input to scan_delta and read_delta #19229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19229 +/- ##
==========================================
+ Coverage 79.99% 80.01% +0.02%
==========================================
Files 1527 1527
Lines 209203 209208 +5
Branches 2415 2417 +2
==========================================
+ Hits 167352 167400 +48
+ Misses 41303 41259 -44
- Partials 548 549 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions (typing, error message), but otherwise I think allowing DeltaTable input here makes plenty of sense 👍
Co-authored-by: Alexander Beedie <[email protected]>
Co-authored-by: Alexander Beedie <[email protected]>
Co-authored-by: Alexander Beedie <[email protected]>
Co-authored-by: Alexander Beedie <[email protected]>
Co-authored-by: Alexander Beedie <[email protected]>
@alexander-beedie I accepted the tweaks but the code coverage doesn't like it. I'm not sure why, maybe it just needs a retry. |
Yup, those failures are unrelated. |
#19074