Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Allow DeltaTable input to scan_delta and read_delta #19229

Merged

Conversation

deanm0000
Copy link
Collaborator

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (900dc3b) to head (05da8d3).

Files with missing lines Patch % Lines
py-polars/polars/io/delta.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19229      +/-   ##
==========================================
+ Coverage   79.99%   80.01%   +0.02%     
==========================================
  Files        1527     1527              
  Lines      209203   209208       +5     
  Branches     2415     2417       +2     
==========================================
+ Hits       167352   167400      +48     
+ Misses      41303    41259      -44     
- Partials      548      549       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions (typing, error message), but otherwise I think allowing DeltaTable input here makes plenty of sense 👍

py-polars/polars/io/delta.py Outdated Show resolved Hide resolved
py-polars/polars/io/delta.py Show resolved Hide resolved
py-polars/polars/io/delta.py Outdated Show resolved Hide resolved
py-polars/polars/io/delta.py Outdated Show resolved Hide resolved
py-polars/polars/io/delta.py Outdated Show resolved Hide resolved
@deanm0000
Copy link
Collaborator Author

@alexander-beedie I accepted the tweaks but the code coverage doesn't like it. I'm not sure why, maybe it just needs a retry.

@alexander-beedie
Copy link
Collaborator

@alexander-beedie I accepted the tweaks but the code coverage doesn't like it. I'm not sure why, maybe it just needs a retry.

Yup, those failures are unrelated.

@alexander-beedie alexander-beedie merged commit fa7207c into pola-rs:main Oct 17, 2024
12 of 13 checks passed
@alexander-beedie alexander-beedie deleted the let_scan_delta_take_deltatable branch October 17, 2024 06:12
@alexander-beedie alexander-beedie restored the let_scan_delta_take_deltatable branch October 17, 2024 06:12
@alexander-beedie alexander-beedie changed the title feat: Allow DeltaTable input to scan_delta and read_delta feat(python): Allow DeltaTable input to scan_delta and read_delta Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants