fix(python): Ensure that read_database
takes advantage of Arrow return from a duckdb_engine
connection when using a SQLAlchemy Selectable
#19255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19221.
Improves
read_database
integration with DuckDB, when using a SQLAlchemy-basedduckdb_engine
connection.Previously we accessed the raw connection directly in order to take advantage of native Arrow return, but this didn't work when using a SQLAlchemy
Selectable
as the query.Now we handle this case properly, as it turns out that
duckdb_engine
supports transparent pass-through to the underlying raw connection (via__getitem__
on the Cursor), allowing us to take advantage of DuckDB's Arrow return in all cases, for maximum performance, without having to interact with the raw connection ourselves.Example
Setup (assuming
duckdb_engine
installed):Provide
read_database
query as a SQLAlchemySelectable
object:(previously this raised an error - now it returns data to Polars via Arrow)