Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pyarrow-stubs #19259

Closed
wants to merge 2 commits into from
Closed

Conversation

deanm0000
Copy link
Collaborator

This is an incomplete first pass, there's a lot more to update.

Also, when I do a make fmt it comes back with a lot of issues that are completely unrelated to pyarrow.

One gotcha is that you have to import the submodules with this syntax from pyarrow import compute as pc

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 16, 2024
@ritchie46
Copy link
Member

I am not sure about this. If we use py-arrow stubs, I want them maintained by pyarrow. Otherwise we have to bear the maintenance and synchronization of this.

@deanm0000
Copy link
Collaborator Author

I am not sure about this. If we use py-arrow stubs, I want them maintained by pyarrow. Otherwise we have to bear the maintenance and synchronization of this.

That makes sense. There was a thread in the pyarrow repo where it was contemplated by both the maintainer of stubs and one of the pyarrow devs that it would eventually be donated/subsumed into apache pyarrow.

I think if that's the main sticking point for polars to adopt it, it might motivate them to push that process forward.

@ritchie46
Copy link
Member

I think if that's the main sticking point for polars to adopt it, it might motivate them to push that process forward.

Yes, if pyarrow support stubs we would use them ofcourse. Until then I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants