Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Use size_of/align_of from prelude #19311

Merged
merged 5 commits into from
Oct 19, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 18, 2024

This has apparently been possible since Rust 1.80.

@orlp orlp changed the title refactor(rust): size_of/align_of are in prelude since 1.80 refactor(rust): Use size_of/align_of from prelude Oct 18, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars and removed title needs formatting labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 78.07018% with 25 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (dae6cd9) to head (c743fcd).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...rates/polars-arrow/src/compute/aggregate/memory.rs 16.66% 5 Missing ⚠️
crates/polars-core/src/frame/group_by/perfect.rs 0.00% 5 Missing ⚠️
...tes/polars-parquet/src/arrow/write/binary/basic.rs 0.00% 3 Missing ⚠️
crates/polars-arrow/src/io/ipc/read/read_basic.rs 33.33% 2 Missing ⚠️
...ates/polars-core/src/chunked_array/ops/bit_repr.rs 66.66% 2 Missing ⚠️
crates/polars-utils/src/arena.rs 0.00% 2 Missing ⚠️
crates/polars-arrow/src/bitmap/aligned.rs 50.00% 1 Missing ⚠️
...rates/polars-arrow/src/io/avro/read/deserialize.rs 83.33% 1 Missing ⚠️
...tes/polars-arrow/src/io/ipc/write/serialize/mod.rs 50.00% 1 Missing ⚠️
crates/polars-core/src/utils/mod.rs 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19311      +/-   ##
==========================================
+ Coverage   80.00%   80.05%   +0.04%     
==========================================
  Files        1528     1531       +3     
  Lines      209850   210020     +170     
  Branches     2419     2434      +15     
==========================================
+ Hits       167894   168132     +238     
+ Misses      41405    41333      -72     
- Partials      551      555       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a871f8c into pola-rs:main Oct 19, 2024
20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants