-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update by
param description for rolling_*_by functions
#19715
base: main
Are you sure you want to change the base?
Conversation
by
docs for rolling_*_by functionsby
docs for rolling_*_by functions
by
docs for rolling_*_by functionsby
param description for rolling_*_by functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the types (U)Int32
/ (U)Int64
are allowed because they can be interpreted as a timestamp (number of some-fraction-of-a-second since epoch), right?
Would it make sense to add a note regarding that?
Someone might be left thinking that (U)Ints of smaller precisions could still work and we just forgot to add them to the docstring..?
Dunno, just asking. Feel free to ignore 😬
thanks for your review - they're allowed because you pass |
Ah I see. Then the docstrings should probably say something about the |
it's ok i can add it, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19715 +/- ##
=======================================
Coverage 79.53% 79.53%
=======================================
Files 1563 1563
Lines 217124 217124
Branches 2464 2464
=======================================
+ Hits 172680 172694 +14
+ Misses 43884 43870 -14
Partials 560 560 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the docs clearer! 🚀
closes #19491