Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Split file of lazyframe methods #19937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Nov 23, 2024

As with DataFrame, it would be better to split the io-related functions into separate files for LazyFrame as well.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Nov 23, 2024
@eitsupi eitsupi marked this pull request as draft November 23, 2024 05:11
@eitsupi eitsupi marked this pull request as ready for review November 23, 2024 05:27
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 99.34354% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.48%. Comparing base (414d883) to head (0bca62c).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/lazyframe/io.rs 99.34% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #19937       +/-   ##
===========================================
+ Coverage   59.28%   79.48%   +20.19%     
===========================================
  Files        1555     1556        +1     
  Lines      216180   216181        +1     
  Branches     2456     2456               
===========================================
+ Hits       128155   171824    +43669     
+ Misses      87467    43799    -43668     
  Partials      558      558               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant