Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add maintain_order parameter to joins #20026

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

stijnherfst
Copy link
Collaborator

@stijnherfst stijnherfst commented Nov 27, 2024

The API docs specify the ordering for left joins as preserving the order of the left Dataframe. In some cases it can be useful to also have this property for other types of joins and in other cases having no required ordering can allow for performance optimizations.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 85.39326% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (58f763a) to head (9c4b32a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...s/polars-ops/src/frame/join/dispatch_left_right.rs 78.37% 16 Missing ⚠️
crates/polars-ops/src/frame/join/mod.rs 89.74% 4 Missing ⚠️
crates/polars-python/src/conversion/mod.rs 69.23% 4 Missing ⚠️
crates/polars-ops/src/frame/join/args.rs 66.66% 1 Missing ⚠️
crates/polars-ops/src/frame/join/hash_join/mod.rs 96.55% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #20026    +/-   ##
========================================
  Coverage   79.53%   79.53%            
========================================
  Files        1563     1563            
  Lines      217115   217230   +115     
  Branches     2464     2464            
========================================
+ Hits       172679   172772    +93     
- Misses      43876    43898    +22     
  Partials      560      560            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/polars-lazy/src/frame/mod.rs Outdated Show resolved Hide resolved
crates/polars-lazy/src/frame/mod.rs Outdated Show resolved Hide resolved
crates/polars-ops/src/frame/join/args.rs Outdated Show resolved Hide resolved
py-polars/polars/dataframe/frame.py Outdated Show resolved Hide resolved
py-polars/polars/lazyframe/frame.py Outdated Show resolved Hide resolved
crates/polars-ops/src/frame/join/args.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants