Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add example and tests for pl.concat() with Expr #20031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: Add example and tests for pl.concat() with Expr #20031

wants to merge 1 commit into from
+38 −4

Conversation

etiennebacher
Copy link
Contributor

Fixes #19813

@etiennebacher etiennebacher changed the title docs: Add example and tests for pl.concat() with Expr input docs: Add example and tests for pl.concat() with Expr Nov 27, 2024
@etiennebacher etiennebacher changed the title docs: Add example and tests for pl.concat() with Expr docs: Add example and tests for pl.concat() with Expr Nov 27, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Nov 27, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.49%. Comparing base (7c97625) to head (fd8665c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #20031   +/-   ##
=======================================
  Coverage   79.49%   79.49%           
=======================================
  Files        1556     1556           
  Lines      216527   216530    +3     
  Branches     2456     2457    +1     
=======================================
+ Hits       172136   172139    +3     
  Misses      43833    43833           
  Partials      558      558

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MarcoGorelli
MarcoGorelli approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @etiennebacher !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should pl.concat() accept Expr input?
2 participants
@etiennebacher @MarcoGorelli