Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Enable view arrow export in write_delta #20092

Merged

Conversation

ion-elgreco
Copy link
Contributor

In next deltalake 0.22.3 release the view types will be fully supported.

Only merge once 0.22.3 is released

cc @ritchie46

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (1f104f9) to head (53a233b).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/dataframe/frame.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20092      +/-   ##
==========================================
- Coverage   79.53%   79.53%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      217124   217119       -5     
  Branches     2464     2465       +1     
==========================================
- Hits       172680   172675       -5     
+ Misses      43884    43883       -1     
- Partials      560      561       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Nice, can you ping once it is released?

@@ -4316,7 +4321,6 @@ def write_delta(
schema=schema,
mode=mode,
storage_options=storage_options,
large_dtypes=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If version <= 0.22.3 we should still pass large_dtypes=True, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since v0.19 that parameter doesn't do anything when the Rust engine is used for writing, which is the default. I'll change the minimum in pyproject.toml to >=0.19

@ion-elgreco ion-elgreco changed the title feat: enable view arrow export in write_delta feat(python): Enable view arrow export in write_delta Dec 2, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars and removed title needs formatting labels Dec 2, 2024
@ritchie46
Copy link
Member

Btw, we can merge this already right? Why do we need to wait on the release? ^^

@ion-elgreco
Copy link
Contributor Author

Btw, we can merge this already right? Why do we need to wait on the release? ^^

We don't actually since we do version check :P, let's merge it then!

@ritchie46 ritchie46 merged commit ec52966 into pola-rs:main Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants