feat: Add assert_err and assert_warn
#20100
Open
+661
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the `assert_eq` and `assert_warn` methods on `LazyFrame` and `DataFrame`. These methods take a set of (possibly named) properties and verify during execution that these properties hold for all values. If a property does not hold, it will throw an error or a warning, respectively. These methods are currently unstable, but I think they can be marked as stable relatively quickly.
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa,
wence- and
orlp
as code owners
coastalwhite
changed the title
assert_err and assert_warn.assert_err and assert_warn
github-actions
bot
added
enhancement
ritchie46
reviewed
Dec 2, 2024
| @@ -278,6 +278,53 @@ fn create_physical_plan_impl( | |||
| streamable, | |||
| ))) | |||
| }, | |||
| Assert { | |||
There was a problem hiding this comment.
I don't think it should be a top level node, but rather on MapFunction. Then most functionality will roll out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
assert_eqandassert_warnmethods onLazyFrameandDataFrame. These methods take a set of (possibly named) properties and verify during execution that these properties hold for all values. If a property does not hold, it will throw an error or a warning, respectively.These methods are currently unstable, but I think they can be marked as stable relatively quickly.