Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): Update pyo3 and numpy crates to version 0.23 #20111

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bschoenmaeckers
Copy link

Updated to latest pyo3 while ignoring most deprecations for now.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (58f763a) to head (c4b62c3).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/map/series.rs 60.00% 16 Missing ⚠️
crates/polars-python/src/cloud.rs 33.33% 4 Missing ⚠️
crates/polars-python/src/map/lazy.rs 69.23% 4 Missing ⚠️
crates/polars-python/src/conversion/mod.rs 50.00% 3 Missing ⚠️
crates/polars-error/src/lib.rs 0.00% 2 Missing ⚠️
crates/polars-python/src/dataframe/export.rs 93.93% 2 Missing ⚠️
crates/polars-python/src/dataframe/serde.rs 0.00% 2 Missing ⚠️
crates/polars-python/src/file.rs 84.61% 2 Missing ⚠️
crates/polars-python/src/conversion/any_value.rs 66.66% 1 Missing ⚠️
crates/polars-python/src/dataframe/general.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20111      +/-   ##
==========================================
- Coverage   79.53%   79.52%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      217115   217088      -27     
  Branches     2464     2464              
==========================================
- Hits       172679   172642      -37     
- Misses      43876    43886      +10     
  Partials      560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego changed the title chore: update to pyo3 v0.23 build: Update pyo3 and numpy crates to version 0.23 Dec 2, 2024
@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Dec 2, 2024
@stinodego stinodego changed the title build: Update pyo3 and numpy crates to version 0.23 build(python): Update pyo3 and numpy crates to version 0.23 Dec 2, 2024
@stinodego stinodego removed the rust Related to Rust Polars label Dec 2, 2024
@stinodego
Copy link
Member

stinodego commented Dec 3, 2024

@bschoenmaeckers Thanks for picking this up! Looks like the new PyO3 version causes deadlock somewhere - can you reproduce this locally? There's probably a clue in the migration guide somewhere on what could be causing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants