Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust!): Remove dedicated sink_(parquet/ipc)_cloud functions #20164

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nameexhaustion
Copy link
Collaborator

sink_parquet/sink_ipc can now be used directly for cloud paths

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (cbc0ea0) to head (1f999aa).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/options.rs 0.00% 8 Missing ⚠️
crates/polars-pipe/src/pipeline/convert.rs 95.65% 1 Missing ⚠️
crates/polars-plan/src/client/check.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20164      +/-   ##
==========================================
+ Coverage   79.58%   79.63%   +0.05%     
==========================================
  Files        1564     1564              
  Lines      217475   217445      -30     
  Branches     2472     2472              
==========================================
+ Hits       173070   173173     +103     
+ Misses      43837    43704     -133     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 5, 2024 10:28
@ritchie46 ritchie46 merged commit bdf4512 into pola-rs:main Dec 5, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants