refactor: Remove debug asserts on scratch space #20224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
changed the title
github-actions
bot
added
internal
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
nameexhaustion
changed the title
nameexhaustion
commented
Dec 9, 2024
| @@ -45,7 +45,8 @@ mod inner { | |||
| } | |||
| } | |||
|
|
|||
| pub(super) fn nodes_scratch_mut(&mut self) -> &mut UnitVec<Node> { | |||
| /// Returns shared scratch space after clearing. | |||
| pub(super) fn empty_nodes_scratch_mut(&mut self) -> &mut UnitVec<Node> { | |||
There was a problem hiding this comment.
rename and add doc
nameexhaustion
commented
Dec 9, 2024
| @@ -146,7 +146,6 @@ pub fn pushdown_eligibility( | |||
| expr_arena: &mut Arena<AExpr>, | |||
| scratch: &mut UnitVec<Node>, | |||
| ) -> PolarsResult<(PushdownEligibility, PlHashMap<PlSmallStr, PlSmallStr>)> { | |||
| debug_assert!(scratch.is_empty()); | |||
There was a problem hiding this comment.
removed assert here
nameexhaustion
commented
Dec 9, 2024
| @@ -50,7 +51,6 @@ fn can_pushdown_slice_past_projections( | |||
| arena: &Arena<AExpr>, | |||
| scratch: &mut UnitVec<Node>, | |||
| ) -> (bool, bool) { | |||
| debug_assert!(scratch.is_empty()); | |||
There was a problem hiding this comment.
removed assert here
nameexhaustion
commented
Dec 9, 2024
| m @(Select {..}, None) | | ||
| m @ (SimpleProjection {..}, _) | ||
| m @ (Select {..}, None) | ||
| | m @ (HStack {..}, None) |
There was a problem hiding this comment.
The original MRE of the panic didn't actually contain a slice() - I realized this was because we were always checking the projections even when we didn't need to for with_columns()
nameexhaustion
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20224 +/- ##
==========================================
- Coverage 79.63% 79.63% -0.01%
==========================================
Files 1565 1565
Lines 218192 218190 -2
Branches 2475 2475
==========================================
- Hits 173749 173745 -4
- Misses 43876 43878 +2
Partials 567 567 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always
clear()insteadwith_columns()