Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Cache dtype on ExprIR #20331

Merged
merged 2 commits into from
Dec 17, 2024
Merged

perf: Cache dtype on ExprIR #20331

merged 2 commits into from
Dec 17, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 17, 2024
@ritchie46 ritchie46 changed the title feat: Cache dtype on ExprIR perf: Cache dtype on ExprIR Dec 17, 2024
@github-actions github-actions bot added the performance Performance issues or improvements label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (e03555c) to head (dc5a7b9).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/expr_ir.rs 93.87% 3 Missing ⚠️
...ates/polars-stream/src/physical_plan/lower_expr.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20331   +/-   ##
=======================================
  Coverage   79.49%   79.50%           
=======================================
  Files        1569     1569           
  Lines      218634   218676   +42     
  Branches     2462     2462           
=======================================
+ Hits       173799   173848   +49     
+ Misses      44267    44260    -7     
  Partials      568      568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b82b2b2 into main Dec 17, 2024
21 checks passed
@ritchie46 ritchie46 deleted the dtype branch December 17, 2024 10:15
@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants