Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rust): Drop probe tables in parallel in new-streaming equi-join #20373

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Dec 19, 2024

This was a partial single-threaded bottleneck.

@github-actions github-actions bot added performance Performance issues or improvements rust Related to Rust Polars labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.09%. Comparing base (db1684d) to head (d65c712).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20373      +/-   ##
==========================================
- Coverage   79.10%   79.09%   -0.01%     
==========================================
  Files        1572     1572              
  Lines      219958   219962       +4     
  Branches     2465     2465              
==========================================
- Hits       173991   173986       -5     
- Misses      45399    45408       +9     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 2a5832a into pola-rs:main Dec 20, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants