refactor!: remove <Series>$compare()
#1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
commented
Nov 2, 2024
| unwrap(paste0("in $compare() with operator `", op, "`:")) | ||
| #' @export | ||
| `==.RPolarsSeries` = function(s1, s2) { | ||
| pl$select(pl$lit(s1)$eq(pl$lit(as_polars_series(s2))$cast(s1$dtype)))$to_series() |
There was a problem hiding this comment.
It should be noted that although cast is added to pass existing tests (presumably tested to mimic the behavior of Python Polars), this leads to some rather strange behavior. (pola-rs/polars#19603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #1271
This does not exist in Python Polars and can no longer be maintained since the Rust functions used internally have been removed.