Skip to content

Commit

Permalink
Merge pull request #6 from polarity-lang/fix-clippy-hints
Browse files Browse the repository at this point in the history
Fix clippy hints
  • Loading branch information
BinderDavid authored May 12, 2024
2 parents 6084454 + db25b9e commit c861bd6
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/file.rs
Original file line number Diff line number Diff line change
@@ -196,7 +196,7 @@ where
/// let mut files = Files::new();
/// let file_id = files.add("test", source);
///
/// assert_eq!(files.source_span(file_id), Span::from_str(source));
/// assert_eq!(files.source_span(file_id), Span::from_string(source));
/// ```
pub fn source_span(&self, file_id: FileId) -> Span {
self.get(file_id).source_span()
@@ -355,7 +355,7 @@ where
}

pub fn source_span(&self) -> Span {
Span::from_str(self.source.as_ref())
Span::from_string(self.source.as_ref())
}

pub fn source_slice(&self, span: Span) -> Result<&str, Error> {
5 changes: 5 additions & 0 deletions src/index.rs
Original file line number Diff line number Diff line change
@@ -33,6 +33,7 @@ impl LineIndex {
}
}

#[allow(clippy::derivable_impls)]
impl Default for LineIndex {
fn default() -> LineIndex {
LineIndex(0)
@@ -82,6 +83,7 @@ impl fmt::Display for LineNumber {
#[derive(Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
pub struct LineOffset(pub RawOffset);

#[allow(clippy::derivable_impls)]
impl Default for LineOffset {
fn default() -> LineOffset {
LineOffset(0)
@@ -125,6 +127,7 @@ impl ColumnIndex {
}
}

#[allow(clippy::derivable_impls)]
impl Default for ColumnIndex {
fn default() -> ColumnIndex {
ColumnIndex(0)
@@ -167,6 +170,7 @@ impl fmt::Display for ColumnNumber {
#[derive(Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
pub struct ColumnOffset(pub RawOffset);

#[allow(clippy::derivable_impls)]
impl Default for ColumnOffset {
fn default() -> ColumnOffset {
ColumnOffset(0)
@@ -198,6 +202,7 @@ impl ByteIndex {
}
}

#[allow(clippy::derivable_impls)]
impl Default for ByteIndex {
fn default() -> ByteIndex {
ByteIndex(0)
4 changes: 2 additions & 2 deletions src/span.rs
Original file line number Diff line number Diff line change
@@ -33,11 +33,11 @@ impl Span {
/// ```rust
/// use codespan::{ByteIndex, Span};
///
/// let span = Span::from_str("hello");
/// let span = Span::from_string("hello");
///
/// assert_eq!(span, Span::new(0, 5));
/// ```
pub fn from_str(s: &str) -> Span {
pub fn from_string(s: &str) -> Span {
Span::new(0, s.len() as u32)
}

0 comments on commit c861bd6

Please sign in to comment.