[RFC] Set --track when creating a worktree #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User should be able to define any upstream string using --set-upstream-to.
rbmarliere
commented
Jul 22, 2024
| @@ -145,6 +153,11 @@ function M.create_worktree_job(path, branch, found_branch) | |||
| table.insert(worktree_add_args, branch) | |||
| end | |||
|
|
|||
| if found_upstream then | |||
There was a problem hiding this comment.
Actually, it only makes sense to use --track when the branch does not exist and -b is used in git-worktree add.
|
I have improved it a bit in my main branch, please let me know if you have interest so I can prepare a proper PR. |
|
I am interested. I am entering a busy period of the year. I will try to find time to look into it soon |
|
Understood! I will send a proper PR later on then :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not to be merged because it is based off these other two: #18 #19
Basically, instead of using git-branch with --set-upstream-to after creating a worktree, the plugin should simply use git-worktree --track instead. That would simplify things a lot for the case where upstream ~= nil in worktree.lua. I wanted to ask you what do you think the best approach should be here.
Thanks,