dst: fix data verification logic #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the verification logic to expect all successfully written timestamps except when there was an error writing a value to the WAL. Previously, the fake log store was accumulating correctly written values but this wasn't much use so it has been changed to accumulate values that could not be written to the WAL and removing those from the expected values.
asubiotto
force-pushed
the
asubiotto-dstfixes
branch
from
085dfc8
to
3fdf999
Compare
thorfour
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the verification logic to expect all successfully written
timestamps except when there was an error writing a value to the WAL.
Previously, the fake log store was accumulating correctly written values but
this wasn't much use so it has been changed to accumulate values that could not
be written to the WAL and removing those from the expected values.
These commits are cherry-picked from #895 in preparation of closing that PR and proposing a new method.