Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of additions and changes #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mlo-poc
Copy link

@mlo-poc mlo-poc commented Aug 30, 2022

I know, it is discouraged to do this.
I started using GradeMan a few years ago and bit by bit I changed it to fit my needs.

  1. added an markdown parser for notes
  2. ported the code to python3
  3. changed the grade-calculation logic
  4. made some minor adjustments I don't really recall

@mlo-poc mlo-poc closed this Aug 30, 2022
@polarwinkel
Copy link
Owner

actually you are encouraged to to this!
Thanks a lot for your changes!
Since I am using my new GradeMan2 I didn't find time to port this to python3, so people are contacting me having issues with newer ubuntu- und debian-versions.
Ad there remain still good reasons to stay with this version, since GradeMan2 is much more designed to be used as your personal cloud server, requiring more knowledge to set it up.

So I'll be glad to have a look at your changes the next days and merge them if all is fine.

@polarwinkel polarwinkel reopened this Nov 8, 2022
@polarwinkel
Copy link
Owner

I just cherry-picked the python3-port and made a new release from that.
I might take a look in your grade-calculation logic some day, but since the pull-request mixes up all your changes its a little more handwork to do.

I saw you forked my GradeMan2 as well, feel free to send pull-requests for that as well! It just would make things a little easier if you could make one request for one certain change.
For example my grade-calculation logic isn't implemented yet ;-)
(I don't use grade calculations and do final grades the pedagogical way, but it's the most asked-for feature, so I planned to implement it and have preparations for that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants