Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Replace versioneer with hard-coded version #141

Closed
wants to merge 1 commit into from
Closed

Conversation

Stoops-ML
Copy link
Collaborator

Version defined in src/czml3/version.txt

@Stoops-ML Stoops-ML marked this pull request as draft June 27, 2024 13:13
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (1a7dd32) to head (02e2b61).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   99.26%   99.25%   -0.01%     
==========================================
  Files          13       12       -1     
  Lines         811      806       -5     
==========================================
- Hits          805      800       -5     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest using this approach https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#dynamic-metadata ?

Hence migrating to pyproject.toml but keeping setuptools, adding a __version__ attribute to czml3/__init__.py, and using that like

[tool.setuptools.dynamic]
version = {attr = "czml3.__version__"}

@Stoops-ML Stoops-ML closed this Jun 28, 2024
@Stoops-ML Stoops-ML deleted the version branch June 28, 2024 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants