Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: data source internal identifier and query sanitizer #9

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

eddydecena
Copy link
Member

@eddydecena eddydecena commented Aug 23, 2024

Description

This PR addresses several key improvements to the data source internal identifier and query sanitizer logic.

Related Issue

NONE

Changes Made

List the specific changes introduced in this PR:

  • Enhances the JWT processing logic to handle incoming user IDs that contain pipe characters (|) by splitting the user ID based on the pipe delimiter.
  • Optimize resource lookup and retrieval by leveraging the data source ID as a primary identifier.
  • Encapsulating all query sanitization rules within a dedicated function, promoting code reusability and maintainability

How Has This Been Tested?

Describe the steps taken to test your changes:

  • Manual testing
    • Verify Completed Platform Life Cycle Functionality

Checklist

  • My code follows the project's coding style guidelines.
  • I have written unit/integration tests where applicable.
  • All new and existing tests passed successfully.
  • I have updated the documentation accordingly.
  • My commit message follows the conversational commit specification.

Additional Notes

Any other relevant information about the PR.

internal/services/ds.service.impl.go Dismissed Show dismissed Hide dismissed
internal/services/ds.service.impl.go Dismissed Show dismissed Hide dismissed
@eddydecena eddydecena changed the title refactor: data source internal identifier refactor: data source internal identifier and query sanitizer Aug 31, 2024
@eddydecena eddydecena marked this pull request as ready for review August 31, 2024 15:32
@eddydecena eddydecena merged commit 878d2a6 into main Aug 31, 2024
3 checks passed
@eddydecena eddydecena deleted the feature/data-source-identifier-ref branch August 31, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant