refactor(tag editor list): convert to .tsx #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchrobot
approved these changes
Feb 14, 2023
| @@ -199,7 +199,7 @@ class AdminTagEditor extends Component { | |||
| <div> | |||
| <TagEditorList | |||
| tags={tagList} | |||
| oEditTag={this.handleEditTag} | |||
| onEditTag={this.handleEditTag} | |||
hiemanshu
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This converts the tag editor list component to a TypeScript functional component.
Motivation and Context
Best practices + easy change while working on #1565 This component is not a direct contributor to the issues described there, so merging #1567 is a higher priority than this PR.
How Has This Been Tested?
This has been tested locally.
Screenshots (if appropriate):
Documentation Changes
Checklist: