Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - remote snippets #231

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

nhussein11
Copy link
Collaborator

@nhussein11 nhussein11 commented Dec 4, 2024

This PR aims to:

  • Fix those links to snippets that weren't updated according to the new IA (mainly asset transfer api page)
  • Remove those snippets that can be replaced by a remote source tied to a specific version or tag

Note: I double checked before pushing, but please review this PR carefully since I made many changes that are prone to error

@nhussein11 nhussein11 requested a review from a team as a code owner December 4, 2024 17:31
@nhussein11 nhussein11 requested a review from 0xLucca December 4, 2024 17:33
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just review the PolkadotSDK version in variables.yml

@@ -16,6 +16,9 @@ dependencies:
polkadot_sdk_solochain_template:
repository_url: https://github.com/paritytech/polkadot-sdk-solochain-template
version: v0.0.2
polkadot_sdk:
repository_url: https://github.com/paritytech/polkadot-sdk
version: v1.16.2-rc1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a stable version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HIGH High priority task Pre-Launch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants