-
Notifications
You must be signed in to change notification settings - Fork 35
Rename Asset Hub to Polkadot / Westend Hub #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a bunch of references to Asset Hub
tutorials/smart-contracts/launch-your-first-project/create-dapp-ethers-js.md
Outdated
Show resolved
Hide resolved
tutorials/smart-contracts/launch-your-first-project/create-dapp-viem.md
Outdated
Show resolved
Hide resolved
tutorials/smart-contracts/launch-your-first-project/test-and-deploy-with-hardhat.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopped reviewing here. Looks like a simple find-and-replace but no effort to change context or use appropriate framing.
Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xLucca I feel like I'm going through and making suggestions to switch things back based on my new understanding of how we should be using Polkadot vs Polkadot Hub vs Polkadot Asset Hub (and related testnet changes). But it's difficult for me to do in a review. I think this deserves a page-by-page review, so we're consistently using the same references throughout a single guide. I feel like if we're not consistent, it's going to cause mass confusion.
So this is as far as I got, some of these recommendations might not be the best ones. Need to see it altogether on the page at once. I can help out with this but I don't think the correct process for this is via a review because I need to see the changes all at once to feel confident about it.
Ok, I pushed up some changes and also commented again on two of my previous comments (see unresolved convos from my last review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! but I believe we should first merge staging into this branch to double check if the updated hardhat page contains some conflicting names or not
Dismissing this review as the requested changes were addressed, but the reviewer has been unresponsive for several weeks. The PR has become stale and needs to move forward. Happy to revisit feedback in a future PR if necessary.
Rename Asset Hub to Polkadot/Westend hub accordingly