Skip to content

[FIX] - Hardhat disclaimer in SC #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

nhussein11
Copy link
Collaborator

This PR complements the hardhat disclaimer regarding code size limitations, explaining the alternative JsonRPCProvider as stated in paritytech/contract-issues#47 (comment)

@nhussein11 nhussein11 requested a review from 0xLucca May 12, 2025 15:57
@nhussein11 nhussein11 self-assigned this May 12, 2025
@nhussein11 nhussein11 requested a review from a team as a code owner May 12, 2025 15:57
@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review C2 - High High priority task A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) labels May 12, 2025
@nhussein11 nhussein11 requested a review from eshaben May 13, 2025 11:35
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one last thing

…t/disclaimer-json-rpc-provider-alternative.js

Co-authored-by: Erin Shaben <[email protected]>
@nhussein11 nhussein11 requested a review from eshaben May 13, 2025 16:06
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels May 13, 2025
@eshaben eshaben merged commit 7cb1054 into staging-ah-smart-contracts May 13, 2025
6 checks passed
@eshaben eshaben deleted the nhussein11/fix-hardhat-disclaimer branch May 13, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) B1 - Ready to Merge Pull request is ready to be merged C2 - High High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants