Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle u64 conversion #1091

Merged

Conversation

tgmichel
Copy link
Contributor

Safe U256 to u64 client side conversion

@tgmichel tgmichel requested a review from sorpaas as a code owner June 27, 2023 09:18
@sorpaas
Copy link
Member

sorpaas commented Jun 27, 2023

Would you mind to use https://paritytech.github.io/substrate/master/sp_arithmetic/traits/trait.UniqueSaturatedFrom.html?

@sorpaas
Copy link
Member

sorpaas commented Jun 28, 2023

Needs to resolve conflicts.

@sorpaas sorpaas merged commit 071d030 into polkadot-evm:master Jul 29, 2023
4 checks passed
sorpaas pushed a commit that referenced this pull request Jul 31, 2023
* Handle `u64` conversion

* suggestion switch to saturated conversion

Co-authored-by: tgmichel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants