chore: support Display/FromStr for AccountId20 in no_std
#1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
approved these changes
May 13, 2024
boundless-forest
approved these changes
May 15, 2024
nazar-pc
reviewed
Jun 21, 2024
| #[derive(Encode, Decode, MaxEncodedLen, TypeInfo)] | ||
| pub struct AccountId20(pub [u8; 20]); | ||
|
|
||
| #[cfg(feature = "serde")] | ||
| impl_serde::impl_fixed_hash_serde!(AccountId20, 20); | ||
|
|
||
| #[cfg(feature = "std")] |
There was a problem hiding this comment.
This is not a correct change. H160::from_str implementation is only available in primitive-types (that sp-core re-exports) if fixed-hash/rustc-hex feature is enabled, which is in turn enabled by primitive-types/rustc-hex, which sp-core only enables when std feature is used.
As the result this can (and does) fail for downstream users unless feature unification accidentally enables fixed-hash/rustc-hex. This should either be reverted or sp-core needs to enable primitive-types/rustc-hex unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.