bound VariadicValue multiple variant #1488
Conversation
|
Does that have a significant performance issue, or could you please provide a detailed example of the case? I find that this code snippet was copied from the previous parity Ethereum, and I wonder why it did not have this restriction before. |
|
@boundless-forest this change comes from an internal review of possible flaws in the code, and we're trying to bound all unbounded inputs.
parity ethereum hasn't been used in production for years, it's not shocking that this client had several flaws that were less annoying at a time when ethereum was much less popular and therefore less hacked. So I wouldn't rely on it. |
Yes. This limit will affect two areas: filter addresses and topics. For topics, a value over 4 is sufficient. However, for addresses, there is no explicitly defined number in the Ethereum protocol. Have you considered the default JSON-RPC payload size restriction? It might address your concern. |
| @@ -30,6 +30,8 @@ use serde_json::{from_value, Value}; | |||
|
|
|||
| use crate::types::{BlockNumberOrHash, Log}; | |||
|
|
|||
| const VARIADIC_MULTIPLE_MAX_SIZE: usize = 16; | |||
There was a problem hiding this comment.
16 will be too low for FilterAddress as mentioned by @boundless-forest
VariadicValue::Multiple variant should be bounded to prevent heavy computation on cartesian product